Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu] Labels in secondary pointing menu items were misaligned #378

Merged
merged 2 commits into from
Jan 11, 2019
Merged

[Menu] Labels in secondary pointing menu items were misaligned #378

merged 2 commits into from
Jan 11, 2019

Conversation

lubber-de
Copy link
Member

@lubber-de lubber-de commented Jan 10, 2019 •
edited
Loading

Description

Putting an inline label for some, but not all menu items in a secondary pointing menu breaks the vertical alignment.
I labeled this as a bug rather than an enhancement as it was in the original SUI issue.

Testcase

http://jsfiddle.net/mgy37rw5/
Remove the CSS to see the issue

Screenshot

Broken

image

Fixed

image

Closes

Semantic-Org/Semantic-UI#5959

@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/css Anything involving CSS state/awaiting-reviews Pull requests which are waiting for reviews tag/sui-issue Taken from an existing Issue/PR of SUI labels Jan 10, 2019
@lubber-de lubber-de added this to the 2.7.x milestone Jan 10, 2019
@lubber-de lubber-de mentioned this pull request Jan 10, 2019
Open
ColinFrick
ColinFrick approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@ColinFrick ColinFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

y0hami
y0hami approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0hami y0hami merged commit 5d9f93a into fomantic:develop Jan 11, 2019
@lubber-de lubber-de deleted the fix/5959/secondary_pointing_menu_label branch January 11, 2019 09:09
@lubber-de lubber-de modified the milestones: 2.7.x, 2.7.2 Jan 11, 2019
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jan 11, 2019
@y0hami y0hami mentioned this pull request Feb 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y0hami y0hami y0hami approved these changes

@ColinFrick ColinFrick ColinFrick approved these changes

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS tag/sui-issue Taken from an existing Issue/PR of SUI type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.2
Development

Successfully merging this pull request may close these issues.
3 participants
@lubber-de @ColinFrick @y0hami